chore: sync all Dart minimum versions to 3.7.0#3171
chore: sync all Dart minimum versions to 3.7.0#3171PureTryOut wants to merge 1 commit intonextcloud:mainfrom
Conversation
PureTryOut
force-pushed
the
dart-version
branch
2 times, most recently
from
df1e1e0 to
ec75399
Compare
PureTryOut
force-pushed
the
dart-version
branch
from
ec75399 to
5f61501
Compare
provokateurin
force-pushed
the
dart-version
branch
from
5f61501 to
979ac94
Compare
|
I rebased the PR and removed the pubspec.lock changes which didn't seem related (and I could not reproduce them after reverting them an running |
|
This seems to trigger a bunch of formatting changes, but to me they look like a step backwards. |
provokateurin
changed the title
|
Seems intentional: dart-lang/dart_style#1652 |
According to https://dart.dev/tools/pub/workspaces 3.6.0 or higher is required for the Pub workspaces feature which we actually use in this repo. Since our CI seems to require 3.7.0 however, let's use that as our new minimum. Signed-off-by: Bart Ribbers <bribbers@disroot.org> Signed-off-by: provokateurin <kate@provokateurin.de>
provokateurin
force-pushed
the
dart-version
branch
from
979ac94 to
f8415b6
Compare
|
I disagree with the fundamental idea of this PR. The monorepo functionality does not change package resolution for downstream users so we do not need to bump it in every pacakge. I also think that we should use a dart version where the formatter is not broken (iirc 3.7 was just a fucked release). |
|
I'm going to work on #3083 to update the flutter version used during development. |
3 participants
According to https://dart.dev/tools/pub/workspaces this version is required for the Pub workspaces feature which we actually use in this repo.